Add equals() function
#770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgauth
reviewed
Apr 29, 2025
tgauth
approved these changes
Apr 30, 2025
andyleejordan
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Ok it's great, and worked, but now I know we also need if (ducks).
2025-04-30T21:58:36.246997Z INFO dsc_lib::configure: 668: Set parameter 'colorMode' to '"dark"'
2025-04-30T21:58:36.247609Z DEBUG dsc_lib::parser: 48: Parsing statement: [if(equals(parameters('colorMode'), 'light'), 1, 0)]
2025-04-30T21:58:36.248239Z DEBUG dsc_lib::parser: 84: Parsing expression
2025-04-30T21:58:36.248858Z DEBUG dsc_lib::parser::expressions: 43: Parsing function '{Node function (0, 1) - (0, 51)}'
2025-04-30T21:58:36.249478Z DEBUG dsc_lib::parser::expressions: 43: Parsing function '{Node function (0, 4) - (0, 44)}'
2025-04-30T21:58:36.250067Z DEBUG dsc_lib::parser::expressions: 43: Parsing function '{Node function (0, 11) - (0, 34)}'
2025-04-30T21:58:36.250790Z DEBUG dsc_lib::parser::functions: 57: Function name: 'parameters'
2025-04-30T21:58:36.253219Z DEBUG dsc_lib::parser::functions: 57: Function name: 'equals'
2025-04-30T21:58:36.253851Z DEBUG dsc_lib::parser::functions: 57: Function name: 'if'
2025-04-30T21:58:36.254457Z DEBUG dsc_lib::parser::functions: 75: Argument is an expression
2025-04-30T21:58:36.255039Z DEBUG dsc_lib::parser::functions: 75: Argument is an expression
2025-04-30T21:58:36.255623Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'String("colorMode")'
2025-04-30T21:58:36.256278Z DEBUG dsc_lib::functions::parameters: 30: parameters function
2025-04-30T21:58:36.256900Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'String("light")'
2025-04-30T21:58:36.257484Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'Number(1)'
2025-04-30T21:58:36.266986Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'Number(0)'
2025-04-30T21:58:36.267733Z ERROR dsc::subcommand: 370: Parameter input failure: Parser: Unknown function 'if'
Comment on lines
+72
to
+73
| // TODO: Add tests for arrays once `createArray()` is implemented | ||
| // TODO: Add tests for objects once `createObject()` is implemented |
There was a problem hiding this comment.
Great, was going to ask based on the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add
equals()function needed for BicepPart of #767